refactor(harness): delete unused browser graph topology (SAP-3090) - #908
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (30)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gwitwer
left a comment
There was a problem hiding this comment.
One thing to fix before this merges, otherwise the deletion is clean.
The CSS rename drops a rule the Agent Map depends on. On main, .system-graph-node-meta had two rules in web/src/styles.css: the overflow/ellipsis one (:4365) and a second one (:4377-4381) with color: var(--text-faint); font-family: var(--font-mono); font-size: var(--type-meta). This PR renames the class on all four Agent Map consumers (AgentMapCanvas.tsx:363 node kind, :408 zoom status, AgentMapInspector.tsx:50 kind, AgentMapPane.tsx:400 header meta) but deletes the second rule (diff around the .system-graph-node-meta { hunks), so those labels now inherit body colour, face and size. No spec asserts computed style, which is why CI is green.
Fix: add the three declarations back on .agent-map-node-meta. A before/after screenshot on the PR would be worth it.
Minor, same file set: api.ts:2994 still mentions __MOCK_SYSTEM_GRAPH_FAIL_ONCE__, which no longer exists.
Everything else checks out: every deleted module, export, test id and class was grepped on the head and only negative assertions remain; graph-viewport and the ELK files are untouched; the deleted viewport module was a pure alias.
Preserve the reviewed history while updating the stack for review fixes.
Preserve the muted monospace metadata role after removing the old graph styles. Cover the computed light and dark styles, attach mock-fixture before and after screenshots, and remove the stale mock failure comment. Refs: SAP-3090
Primary change type
Problem and motivation
After shell entry points were removed, the old project renderer, loaders, topology and mock cache had no supported browser consumers. Keeping them made the retired protocol and ownership boundary ambiguous.
Summary and scope
Delete unused graph components, parser/layout/navigation/grouping helpers, API methods, mock projection, announcements, graph-only fixtures and tests. Move retained viewport coverage to its neutral owner and give retained styles Agent Map names. Preserve the muted monospace metadata role with
--text-faint,--font-monoand--type-meta. Request counters observe actual legacy HTTP paths before boot. Per-agent Canvas and shared viewport math remain in use.Screenshots from the same mock map and viewport:
Related work
Related issue or discussion: SAP-3090. Part of the authorized cleanup stack above #892 and #893, targeting
main. The seven layers are intended to merge and ship together. Updated layers require maintainer approval before merge.Validation
Review-fix verification on cumulative source
5bfed981, including currentmain(8679d745). Server and browser typechecks also passed on each of the seven isolated PR heads.The browser override selects the installed Google Chrome, temporary output paths and
pnpm exec vite; it preserves the checked-in tests and assertions. All 16 focused map/style/project-tab cases passed, including light/dark computed styles, project/agent viewport restoration, offscreen recovery, automatic fitting, auth isolation and layout recovery. The viewport and metadata regressions failed before their fixes. The new viewport and project-altitude tests also passed on #907's own intermediate tree (10 cases).An initial three-worker Harness run failed one archive-wiring case; the affected file passed unchanged 8/8, followed by the complete passing two-worker run above. The
mainintegration passed 263 focused cases, and #892's resolved auth mock passed 4/4 on its own tree. No tests or admission guards were weakened.All PR heads include
main's deliberate removal of the duplicate Claude workflow in #886. The reviewed commits remain in history; the stack update uses ordinary fast-forward pushes. Fresh build hashes and the earlier package/smoke evidence are recorded in the retirement record. Signed macOS installer/upgrade validation remains SAP-3086.Tests and documentation
Retained neutral viewport and analytics coverage; added computed-style checks for map header, node kind and inspector metadata in light and dark themes. Before/after screenshots use only the public mock fixture. Removed the stale mock graph failure comment.
Compatibility and release impact
Security
AI assistance
Codex implemented the cleanup and test/doc migrations, traced retained callers, and checked the resulting diffs. Automated checks above and independent read-only review provide implementation evidence; maintainer review is still required.
Checklist
CONTRIBUTING.md, and this contribution follows the direct-PR or issue-first policy.